Improve general readability #69

Hecate · 2020-09-05T13:16:06+02:00

Hecate commented

2020-09-05 13:16:06 +02:00

This PR brings several readability enhancements:

Text is always unqualified
The Servant API declaration is moved to its own file
Redundant imports are removed

This PR brings several readability enhancements: * `Text` is always unqualified * The Servant API declaration is moved to its own file * Redundant imports are removed

schmittlauch commented

2020-09-05 15:24:58 +02:00

Do you plan on adding something more to this PR, or can this be merged?

schmittlauch reviewed 2020-09-05 15:27:28 +02:00

src/Hash2Pub/PostService.hs Outdated

													
				@ -96,3 +97,3 @@

				              , migrationsInProgress = migrationsInProgress'

				              , httpMan = httpMan'

				                                      }

				              }

schmittlauch commented

2020-09-05 15:27:28 +02:00

I should probaby define a proper indentation style for this project.
My vim plugin places the closing brace below the opening one, but I also insist on only indenting the record elements a single level.

I should probaby define a proper indentation style for this project. My vim plugin places the closing brace below the opening one, but I also insist on only indenting the record elements a single level.

Hecate commented

2020-09-05 15:38:36 +02:00

Poster

Do I revert this change?

schmittlauch commented

2020-09-05 15:44:12 +02:00

Depends on how it got there. Is stylish-haskell able to enforce a consistent indentation style?
Maybe I should also try to properly configure my vim indetations because they are a bit conflicting.

But until then either I or you better revert this indentation.

Depends on how it got there. Is stylish-haskell able to enforce a consistent indentation style? Maybe I should also try to properly configure my vim indetations because they are a bit conflicting. But until then either I or you better revert this indentation.

Hecate commented

2020-09-05 15:46:09 +02:00

Poster

Reverted.