Improve general readability #69

Merged
schmittlauch merged 2 commits from Hecate/Hash2Pub:readability into mainline 2020-09-05 16:27:24 +02:00
Contributor

This PR brings several readability enhancements:

  • Text is always unqualified
  • The Servant API declaration is moved to its own file
  • Redundant imports are removed
This PR brings several readability enhancements: * `Text` is always unqualified * The Servant API declaration is moved to its own file * Redundant imports are removed
Owner

Do you plan on adding something more to this PR, or can this be merged?

Do you plan on adding something more to this PR, or can this be merged?
schmittlauch reviewed 2020-09-05 15:27:28 +02:00
@ -96,3 +97,3 @@
, migrationsInProgress = migrationsInProgress'
, httpMan = httpMan'
}
}
Owner

I should probaby define a proper indentation style for this project.
My vim plugin places the closing brace below the opening one, but I also insist on only indenting the record elements a single level.

I should probaby define a proper indentation style for this project. My vim plugin places the closing brace below the opening one, but I also insist on only indenting the record elements a single level.
Author
Contributor

Do I revert this change?

Do I revert this change?
Owner

Depends on how it got there. Is stylish-haskell able to enforce a consistent indentation style?
Maybe I should also try to properly configure my vim indetations because they are a bit conflicting.

But until then either I or you better revert this indentation.

Depends on how it got there. Is stylish-haskell able to enforce a consistent indentation style? Maybe I should also try to properly configure my vim indetations because they are a bit conflicting. But until then either I or you better revert this indentation.
Author
Contributor

Reverted.

Reverted.
Author
Contributor

@schmittlauch Yep, it's ready to be merged.

@schmittlauch Yep, it's ready to be merged.
schmittlauch closed this pull request 2020-09-05 16:27:24 +02:00
schmittlauch deleted branch readability 2020-09-05 16:27:48 +02:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: schmittlauch/Hash2Pub#69
No description provided.