Trolli Schmittlauch schmittlauch
  • Joined on 2017-06-16
schmittlauch commented on issue schmittlauch/Hash2Pub#18 2020-05-19 19:25:37 +02:00
Main.hs should not live in src/

I'll take care of this at the next larger feature branch merge.

Can you point to some examples for this convention? The Main.hs didn't always reside in src/, but I moved it there after looking at other packages (I guess pandoc was one of those).

schmittlauch opened issue schmittlauch/Hash2Pub#19 2020-05-19 19:22:50 +02:00
background job processing for delivering ActivityPub pushes
schmittlauch pushed to dhtNetworking at schmittlauch/Hash2Pub 2020-05-19 16:52:45 +02:00
0e6f126b3b Merge branch 'master' into dhtNetworking
b8eeb852da Merge pull request 'Linting integration' (#17) from Hecate/Hash2Pub:hlint-configuration into master
7fd369c8c5 add stylish as haskell linter
41e999ed99 Linting integration
d049b65f1e add readme
Compare 6 commits »
schmittlauch merged pull request schmittlauch/Hash2Pub#17 2020-05-19 16:36:00 +02:00
Linting integration
schmittlauch pushed to master at schmittlauch/Hash2Pub 2020-05-19 16:36:00 +02:00
b8eeb852da Merge pull request 'Linting integration' (#17) from Hecate/Hash2Pub:hlint-configuration into master
41e999ed99 Linting integration
Compare 2 commits »
schmittlauch pushed to master at schmittlauch/Hash2Pub 2020-05-19 16:33:03 +02:00
7fd369c8c5 add stylish as haskell linter
schmittlauch pushed to dhtNetworking at schmittlauch/Hash2Pub 2020-05-19 16:31:00 +02:00
84bcd676ae move protocol data definitions to own module to prevent cyclic imports
schmittlauch commented on pull request schmittlauch/Hash2Pub#17 2020-05-19 13:16:50 +02:00
Linting integration

Thanks for these opinionated insights, they're a good starting point for Haskell newbies like me.

I need some clarifications though:

  • Import lines ordering;

Regarding the imports, I am of the school that says “non-local imports are noise, put them on top, and keep the local imports as close as your code as possible”.

So you're basically recommending to put imports of haskell platform and other libraries first, and the module imports from the same package should appear last? I already tried to follow that rule, but may not have been consistent.
What is the import oordering you suggest? base ==> haskell-platform ==> package local imports?

  • Preferring pure over return;

Why should pure be preferred over return in general? I always tried to use both of them depending on the context: When writing applicative-style functions, I used pure to make the applicative nature of the functions obvious, when messing around inside monads (e.g. with do notation) I used return to highlight the monad stuff, even when `pure could've been enough (example: Maybe).

schmittlauch pushed to dhtNetworking at schmittlauch/Hash2Pub 2020-05-19 00:09:54 +02:00
4e62bb08f8 add readme
schmittlauch pushed to master at schmittlauch/Hash2Pub 2020-05-19 00:02:07 +02:00
d049b65f1e add readme
60c164dbb0 remove unnecessary directory level
571fb3dabc fixup! remove unnecessary directory level
4af8a4ce78 more build instructions
6b16ad8033 add readme
Compare 78 commits »
schmittlauch pushed to master at schmittlauch/Hash2Pub 2020-05-18 23:55:25 +02:00
571fb3dabc fixup! remove unnecessary directory level
schmittlauch pushed to master at schmittlauch/Hash2Pub 2020-05-18 22:53:34 +02:00
4af8a4ce78 more build instructions
schmittlauch opened issue schmittlauch/Hash2Pub#16 2020-05-17 23:17:00 +02:00
make payload splitting more efficient
schmittlauch opened issue schmittlauch/Hash2Pub#15 2020-05-17 23:16:27 +02:00
check timestamp and restrict age when adding entries to cache
schmittlauch opened issue schmittlauch/Hash2Pub#14 2020-05-17 23:15:13 +02:00
pass in TOML configuration to parameterise functions
schmittlauch opened issue schmittlauch/Hash2Pub#13 2020-05-17 23:13:52 +02:00
storage node functionality
schmittlauch opened issue schmittlauch/Hash2Pub#12 2020-05-17 23:13:06 +02:00
relay node functionality
schmittlauch opened issue schmittlauch/Hash2Pub#11 2020-05-17 23:11:33 +02:00
testbed
schmittlauch opened issue schmittlauch/Hash2Pub#10 2020-05-17 23:10:46 +02:00
Work as an ActivityPub Relay
schmittlauch opened issue schmittlauch/Hash2Pub#9 2020-05-17 23:09:56 +02:00
Basic ActivityPub interoperability