schmittlauch/youtube-dl
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Don't use bare 'except:'

Browse source 
They catch any exception, including KeyboardInterrupt, we don't want to catch it.
This commit is contained in:
Jaime Marquínez Ferrándiz 2015-03-27 13:02:20 +01:00
parent af14000215
commit 70a1165b32
8 changed files with 16 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

4
youtube_dl/update.py
View file

@ -65,7 +65,7 @@ def update_self(to_screen, verbose):
# Check if there is a new version
try:
newversion = opener.open(VERSION_URL).read().decode('utf-8').strip()
except:
except Exception:
if verbose:
to_screen(compat_str(traceback.format_exc()))
to_screen('ERROR: can\'t find the current version. Please try again later.')
@ -78,7 +78,7 @@ def update_self(to_screen, verbose):
try:
versions_info = opener.open(JSON_URL).read().decode('utf-8')
versions_info = json.loads(versions_info)
except:
except Exception:
if verbose:
to_screen(compat_str(traceback.format_exc()))
to_screen('ERROR: can\'t obtain versions info. Please try again later.')