update node ID validity check to allow different vserver IDs #74

New issue

Closed

opened 2020-09-23 19:17:22 +02:00 by schmittlauch · 1 comment

schmittlauch commented

2020-09-23 19:17:22 +02:00

Owner

No description provided.

schmittlauch added this to the k-choices load balancing milestone 2020-09-23 19:17:22 +02:00

schmittlauch commented

2020-09-29 02:59:32 +02:00

Author

Owner

Turns out that no interval checking needed to be done, because each RemoteNodeState sent with every request inludes the ID of the sending vserver. So no trying out of all the vservers is needed.

Still did a bit of cleanup and refactoring ¯_(ツ)_/¯

Turns out that no interval checking needed to be done, because each RemoteNodeState sent with every request inludes the ID of the sending vserver. So no trying out of all the vservers is needed. Still did a bit of cleanup and refactoring ¯\_(ツ)_/¯

schmittlauch referenced this issue from a commit

2020-09-29 03:01:55 +02:00

change vserver ID representation type to Word8 - performance improvement: avoid unnecessary representation and conversion from/to Integer - part of hot path: with k-choices, all possible IDs are regularly generated and checked - preparation for #74

schmittlauch referenced this issue from a commit

2020-09-29 03:01:55 +02:00

refactor request sender ID spoof check to suit k-choices - mostly refactored the checks into its own function - now additionally check the vserver number limit - refactoring to pass that limit to the checking function invocations - closes #74

schmittlauch closed this issue

2020-09-29 03:02:29 +02:00