schmittlauch/Hash2Pub
1
0
Fork 1
Code Issues 47 Pull requests Releases Wiki Activity

Avoid partial record accessors #27

New issue
Open
opened 2020-05-31 23:32:24 +02:00 by schmittlauch · 0 comments
schmittlauch commented 2020-05-31 23:32:24 +02:00
Owner
Copy link

Record types with multiple constructors, where some accessor functions only work on some of the constructed values, can fail at runtime: Using the accessor function on a value not holding that attribute throws a RecSelError exception.

A better design is to avoid partial records at all.

Idea for refactoring ActionPayload:

  • use one concrete type per payload variant
  • create a sum type of all variants for referencing the payload in FediChordMessage
Record types with multiple constructors, where some accessor functions only work on some of the constructed values, can fail at runtime: Using the accessor function on a value not holding that attribute throws a `RecSelError` exception. A better design is to avoid partial records at all. Idea for refactoring `ActionPayload`: - use one concrete type per payload variant - create a sum type of all variants for referencing the payload in `FediChordMessage`
schmittlauch added the
refactoring
 label 2020-05-31 23:32:24 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
mainline
k-choices
measurement_logging
instrumentation
fix_networking
data_migration
refactorRingMap
instrumentation_prototype
Labels
Clear labels   
ActivityPub

   
advanced features

   
basic functionality

   
bug

   
DHT

   
evaluation

   
refactoring

   
security

   
test case

an edge case or usage pattern that needs a test

No labels
ActivityPub
advanced features
basic functionality
bug
DHT
evaluation
refactoring
security
test case
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: schmittlauch/Hash2Pub#27
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?