Refactor common accessor functions of internal and remote NodeState to a type class with 2 types #20

New issue

Closed

opened 2020-05-20 14:30:51 +02:00 by schmittlauch · 0 comments

schmittlauch commented

2020-05-20 14:30:51 +02:00

Owner

Currently, NodeState is used for representing both the internal local nodes. As the local nodes contain local configuration parameters not present in the representation of remote nodes, this InternalNodeState is wrapped into a Maybe.

But these parameteres are mostly accessed in functions that deal with local nodes only anyways. That renders the case disticntion between Just and Nothing to be unnecessary boilerplate.

Proposal:
Create a new type class that contains the accessor functions for values present in both NodeState types. Rename the the current NodeState without internals to RemoteNodeState. The LocalNodeState is a composite type that holds a RemoteNodeState and the internal values, with accessor functions designed to remove that composition indirection.

Currently, `NodeState` is used for representing both the internal local nodes. As the local nodes contain local configuration parameters not present in the representation of remote nodes, this `InternalNodeState` is wrapped into a Maybe. But these parameteres are mostly accessed in functions that deal with local nodes only anyways. That renders the case disticntion between Just and Nothing to be unnecessary boilerplate. **Proposal**: Create a new type class that contains the accessor functions for values present in both NodeState types. Rename the the current `NodeState` without internals to `RemoteNodeState`. The `LocalNodeState` is a composite type that holds a `RemoteNodeState` and the internal values, with accessor functions designed to remove that composition indirection.